agent_skills by d-chambers · Pull Request #613 · DASDAE/dascore

d-chambers · 2026-02-11T14:44:40Z

Description

This PR adds an agents file to help coding agents like codex and claude code work effectively on the DASCore code base. It also adds a skill for generating release notes.

Checklist

I have (if applicable):

referenced the GitHub issue this PR closes.
documented the new feature with docstrings and/or appropriate doc page.
included tests. See testing guidelines.
added the "ready_for_review" tag once the PR is ready to be reviewed.

Summary by CodeRabbit

Documentation
- Added a comprehensive Agent Guide covering scope, contributor workflow, environment setup, linting/formatting, testing and test-authoring conventions, code and documentation standards, uncertainty handling, and quality criteria for agent changes.
- Introduced a draft-release workflow to determine the next semantic version and generate a categorized changelog from merged PRs.
- Added a root-level canonical reference instructing agents to load the canonical guide before making changes.

coderabbitai · 2026-02-11T14:45:00Z

Walkthrough

Three new documentation files were added: AGENTS.md (root pointer), .agents/agents.md (comprehensive DASCore Agent Guide), and .agents/skills/draft-release/SKILL.md (draft-release skill describing semantic-version computation and changelog drafting). No code or public API changes.

Changes

Cohort / File(s)	Summary
Root agent pointer `AGENTS.md`	Adds a repository-level pointer instructing agents to load canonical instructions from `.agents/agents.md`.
Agent guide `.agents/agents.md`	New comprehensive agent contributor guide covering scope, development workflow, environment setup, linting/formatting, testing and test-authoring conventions, code/documentation conventions, quality bar, and uncertainty handling. No behavioral or API changes.
Draft-release skill `.agents/skills/draft-release/SKILL.md`	New skill document specifying inputs (`release_type`), permission prompts, `git fetch --all --tags`, rules to derive next `vX.Y.Z` from `v`-prefixed semver tags (base `v0.0.0` if none), bump semantics, PR collection range and metadata, deterministic changelog classification (New Features / Bug Fixes / Breaking Changes), sorting and output format, and examples. No code or API changes.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'agent_skills' is vague and generic, using a non-descriptive term that doesn't clearly convey the main purpose of adding agent guidance documentation and release note generation skill.	Improve the title to be more descriptive, such as 'Add agent guidelines and draft-release skill' to clearly communicate the primary changes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description check	✅ Passed	The PR description adequately explains the main additions (agent guidance file and release notes skill) and includes the required checklist template, though no checklist items are marked as completed.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch agent_skills

No actionable comments were generated in the recent review. 🎉

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c99916d950

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-11T14:46:38Z

.agents/skills/draft-release/SKILL.md

+
+2. Determine the next version number:
+- Consider only tags that start with `v` and match strict semver:
+  `^v[0-9]+\\.[0-9]+\\.[0-9]+$` (ignore pre-release/build suffixes).


Use single-escaped dots in semver regex

The semver pattern is documented as ^v[0-9]+\\.[0-9]+\\.[0-9]+$, which matches a literal backslash before each dot when used directly in common regex tools; this means tags like v1.2.3 will not match and the workflow can incorrectly fall back to v0.0.0, yielding the wrong next version and an incorrect PR range for changelog generation.

Useful? React with 👍 / 👎.

coderabbitai

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In @.agents/agents.md:
- Around line 63-67: Edit the "## Test authoring conventions" section (heading
text) to remove the trailing space after the period on the sentence at line 66
and replace any occurrences of the word "bugfixes" with the two-word form "bug
fixes" for consistency; apply the same "bugfixes" → "bug fixes" change in the
other instance mentioned (around lines 99–104). Locate those terms within the
.agents/agents.md content and update the punctuation and wording accordingly so
the sentence has no trailing space and the wording matches the project's style.

In @.agents/skills/draft-release/SKILL.md:
- Around line 17-21: Remove the stray blank "1." line in SKILL.md and renumber
the subsequent checklist items so numbering is contiguous (e.g., change the
duplicate "1." and the following items to "1.", "2.", "3.", etc.); locate the
checklist block that starts with "0. Ask for elevated permissions..." and edit
the list so there are no empty numbered lines and no duplicate step numbers.

coderabbitai · 2026-02-11T14:47:08Z

.agents/agents.md

+## Test authoring conventions
+
+- Put tests under `tests/` mirroring package structure.
+- Group tests in classes. 
+- Place fixtures as close as practical to usage (class, module, then `conftest.py`).


⚠️ Potential issue | 🟡 Minor

Minor doc polish: extra space + wording consistency.
Line 66 has a trailing space after the period, and “bugfixes” could be standardized to “bug fixes” for consistency with other sections.

✏️ Proposed edit

- - Group tests in classes. + - Group tests in classes. @@ - 5. No unrelated refactors bundled with bugfixes. + 5. No unrelated refactors bundled with bug fixes.

Also applies to: 99-104

🤖 Prompt for AI Agents

In @.agents/agents.md around lines 63 - 67, Edit the "## Test authoring conventions" section (heading text) to remove the trailing space after the period on the sentence at line 66 and replace any occurrences of the word "bugfixes" with the two-word form "bug fixes" for consistency; apply the same "bugfixes" → "bug fixes" change in the other instance mentioned (around lines 99–104). Locate those terms within the .agents/agents.md content and update the punctuation and wording accordingly so the sentence has no trailing space and the wording matches the project's style.

.agents/skills/draft-release/SKILL.md

codspeed-hq · 2026-02-11T15:15:57Z

Merging this PR will not alter performance

✅ 54 untouched benchmarks

_{Comparing agent_skills (19925d3) with master (ed063fd)}

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In @.agents/skills/draft-release/SKILL.md:
- Around line 24-33: The documented regex in the "Determine the next version
number" block uses double backslashes (`^v[0-9]+\\.[0-9]+\\.[0-9]+$`); update
that pattern to use single backslashes so it reads `^v[0-9]+\.[0-9]+\.[0-9]+$`
to ensure compatibility with standard regex engines (grep, sed, JS RegExp,
Python re) and any agents parsing SKILL.md.

🧹 Nitpick comments (1)

.agents/skills/draft-release/SKILL.md (1)

48-57: Consider clarifying the conventional commit ! check.

Line 50 mentions checking if the title "contains ! in conventional-commit style segment" but doesn't specify where the ! should appear. Conventional commits typically use type!: description format where ! appears after the type and before the colon (e.g., feat!: breaking feature).

You could clarify whether agents should:

Check for ! anywhere in the title (simpler, more permissive), or

Check for the specific conventional commit pattern (more precise)

The current description works but could reduce ambiguity in implementation.

.agents/skills/draft-release/SKILL.md

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In @.agents/skills/draft-release/SKILL.md:
- Around line 17-40: Update the Step 0 permission prompt in SKILL.md to request
permissions that match the GH CLI commands actually used to collect merged PRs
(e.g., gh pr list, gh pr view, gh api) instead of gh issue view; modify the
wording so it explicitly asks for network access and the ability to run git
fetch and the specific GH CLI PR commands (or gh api) used by the skill,
ensuring the permission text aligns with steps that call fetching refs and
reading merged PRs.

.agents/skills/draft-release/SKILL.md

agent_skills

c99916d

chatgpt-codex-connector bot reviewed Feb 11, 2026

View reviewed changes

coderabbitai bot reviewed Feb 11, 2026

View reviewed changes

Fix doc nits from PR review

428d5c3

coderabbitai bot reviewed Feb 11, 2026

View reviewed changes

.agents/skills/draft-release/SKILL.md Show resolved Hide resolved

update skill regex

1904b50

coderabbitai bot reviewed Feb 12, 2026

View reviewed changes

.agents/skills/draft-release/SKILL.md Outdated Show resolved Hide resolved

update permissions

19925d3

d-chambers merged commit a80f225 into master Feb 12, 2026
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

agent_skills#613

agent_skills#613
d-chambers merged 4 commits intomasterfrom
agent_skills

d-chambers commented Feb 11, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 11, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 11, 2026

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Feb 11, 2026

Uh oh!

Uh oh!

codspeed-hq bot commented Feb 11, 2026 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

d-chambers commented Feb 11, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codspeed-hq bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

d-chambers commented Feb 11, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 11, 2026 •

edited

Loading

codspeed-hq bot commented Feb 11, 2026 •

edited

Loading